From 245003348be73131becdaa4a34927b94a15f3041 Mon Sep 17 00:00:00 2001 From: JP Abgrall Date: Wed, 6 Jul 2011 12:05:49 -0700 Subject: [PATCH 346/696] netfilter: qtaguid: fix bad-arg handling when tagging socket When processing args passed to the procfs ctrl, if the tag was invalid it would exit without releasing the spin_lock... Bye bye scheduling. Signed-off-by: JP Abgrall Change-Id: Ic1480ae9d37bba687586094cf6d0274db9c5b28a --- net/netfilter/xt_qtaguid.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/netfilter/xt_qtaguid.c b/net/netfilter/xt_qtaguid.c index 3b5ab3f..3cacec0 100644 --- a/net/netfilter/xt_qtaguid.c +++ b/net/netfilter/xt_qtaguid.c @@ -1065,7 +1065,7 @@ static int qtaguid_ctrl_parse(const char *input, int count) goto ok; err_unlock: - if (!sock_tag_entry) + if (sock_tag_entry) spin_unlock_irqrestore(&sock_tag_list_lock, flags); err: ok: -- 1.7.1